-
-
Notifications
You must be signed in to change notification settings - Fork 124
Minor fixes to beta function parameters and clarifying text for gamma distribution #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting and sorry to have missed this earlier. Other than for making the expectation and variance notation consistent with the rest of our doc these changes look good. I'll just go ahead and fix myself if there's not a response.
|
@bob-carpenter were you going to do something more for this? |
|
Does this need a more formal review? It has a conflict now that needs to be resolved. Happy to review after that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just going to approve this and try to consolidate notation later since I can't edit the actual PR since it's not coming from Stan-dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Submission Checklist
`r since("VERSION")`Summary
Minor improvements and fixes to documentation.
Note I get tex build errors which seem unrelated to my changes
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Michael Gilchrist
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: